-
Notifications
You must be signed in to change notification settings - Fork 114
Fix tag names for Azure Linux images #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The tag names should match the directory structure, and should include the architecture for arch-specific images.
mthalman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes. It brings consistency and clarity. But I think we need to update the documentation to reflect this pattern because it is a different pattern than what is currently used for non-cross images.
I'm specifically referring to the pattern documented at https://github.com/dotnet/dotnet-buildtools-prereqs-docker?tab=readme-ov-file#how-to-identify-an-image. The difference with the cross images is that the architecture specified refers to the cross target, not the architecture of the image.
|
Thanks! The docs currently say this about the arch:
Personally I like the policy of allowing I propose we:
cc @richlander |
I don't like removing it from the directory name. Because there are some Dockerfiles which are truly multi-arch and so they have no architecture directory. Saying that an For tags, I initially was ambivalent. But thinking more about it, I kind of feel it needs to be explicit because of the ambiguity that arises from it. One could imagine have multi-arch tags for our multi-arch Dockerfiles. And that would most definitely not have an arch in the tag name. So I think the documented pattern should be changed to say that all architectures should be explicit both in tags and directories. |
|
Thanks! Updated the readme to reflect this guidance and also mention the different pattern used for cross-arch images. I updated some of the alpine tags because the docs used alpine as an example. |
Co-authored-by: Matt Thalman <[email protected]>
Add examples for the target
The tag names should match the directory structure, and should include the architecture for arch-specific images.